fix: preserve argument types in max_by/min_by with dictionary inputs #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a type inference issue in
max_byandmin_byaggregate functions when the first argument is a dictionary type.Problem
Previously, when
max_byormin_byreceived a dictionary as the first argument, theget_min_max_by_result_typefunction would only return the dictionary's value type, discarding information about other arguments. This could lead to type mismatches in query planning when the function result was used in subsequent operations.Solution
The fix modifies
get_min_max_by_result_typeto:Testing
max_bywith string/int, string/float, float/string, int/string combinationsmin_bywith the same type combinationsAll tests pass successfully.